Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct Message Subject Header May Contain Multiple Subjects #830

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Direct Message Subject Header May Contain Multiple Subjects #830

merged 1 commit into from
Oct 19, 2023

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Oct 18, 2023

No description provided.

@scottf scottf requested a review from mtmk October 18, 2023 18:23
mtmk
mtmk suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wanted to check if a bounds check is necessary.

src/NATS.Client/MsgHeader.cs Show resolved Hide resolved
@scottf scottf requested a review from mtmk October 18, 2023 21:06
mtmk
mtmk approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 0cb54d1 into main Oct 19, 2023
1 check passed
@scottf scottf deleted the direct-message-last-subject branch October 19, 2023 00:20
@scottf scottf mentioned this pull request Nov 3, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @mtmk