Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub Ack Allow Sequence Zero during Validation #823

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Oct 6, 2023

Zero is a valid sequence for a pub ack

Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit dc86b36 into master Oct 6, 2023
@scottf scottf deleted the pub-ack-validation branch October 6, 2023 22:59
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf changed the title Pub ack validation Pub Ack Allow Sequence Zero during Validation Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants