Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Filter Subjects and Subject Validation #821

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Sep 24, 2023

No description provided.

@scottf scottf changed the title Subject Validation Multiple Filter Subjects and Subject Validation Sep 26, 2023
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general only one or two minor points need clarification.

src/NATS.Client/Internals/Validator.cs Show resolved Hide resolved
src/NATS.Client/Internals/Validator.cs Show resolved Hide resolved
@scottf scottf requested a review from mtmk September 28, 2023 23:07
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 78ae172 into master Sep 29, 2023
@scottf scottf deleted the subject-validation branch September 29, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants