Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and updated Simplification samples #800

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Added and updated Simplification samples #800

merged 2 commits into from
Jul 14, 2023

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Jul 13, 2023

No description provided.

@scottf scottf requested a review from mtmk July 13, 2023 23:24
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IJetStreamManagement jsm = c.CreateJetStreamManagementContext();

// Use the utility to create a stream stored in memory.
JsUtils.CreateOrReplaceStream(jsm, helper.Stream, helper.Subject);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an extension method.

Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 06cdeab into master Jul 14, 2023
@scottf scottf deleted the queue-example branch July 14, 2023 14:39
@scottf scottf changed the title Added and updated Samples Added and updated Simplification samples Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants