Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general testing improvements #660

Merged
merged 8 commits into from
Aug 17, 2022
Merged

general testing improvements #660

merged 8 commits into from
Aug 17, 2022

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Aug 16, 2022

it's flapping, not sure why the comparison is failing even though things are normalized to utc.

@scottf scottf requested a review from arondi August 16, 2022 21:15
@scottf scottf changed the title removing time testing general testing improvements Aug 17, 2022
Copy link
Collaborator

@arondi arondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit e931045 into master Aug 17, 2022
@scottf scottf deleted the test-fixes branch August 17, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants