[Added] CreateUserSeed and CreateAccountSeed so these can be generated #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Hanel <[email protected]>
| /// Creates a private account seed String. | ||
| /// </summary> | ||
| /// <returns>A NATS Ed25519 Account Seed</returns> | ||
| public static string CreateAccountSeed() |
There was a problem hiding this comment.
Perhaps add the others for completeness in case someone want to write a utility out of this... wdyt?
eg.
public static string CreateOperatorSeed();
public static string CreateServerSeed();
public static string CreateClusterSeed();There was a problem hiding this comment.
will add CreateOperatorSeed. Server and Cluster are not used.
| public class TestNkeys | ||
| { | ||
| [Fact] | ||
| public void TestNKEYEncodeDecode() |
There was a problem hiding this comment.
Maybe add seeds created by CreateUserSeed, CreateAccountSeed, etc...
There was a problem hiding this comment.
already have TestNKEYCreateUserSeed and TestNKEYCreateAccountSeed further down, will add the operator one
There was a problem hiding this comment.
LGTM so far. Thanks @matthiashanel! A few requests, certainly open for discussion.
added seed generation for operator + unit test Signed-off-by: Matthias Hanel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Hanel [email protected]
altered visibility for some functions for testing.
Since nkeys don't store the type I am not returning an NKEY and return the seed instead.
That seed can then be used to create the nkey.