-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on Linux (and other stuff) #355
Conversation
- Remove test runs on netcore2.2 (not supported anymore by MSFT) - Use netcoreapp3.1 (current LTS) instead of netcoreapp3.0 for tests
Close & reopen to trigger CI |
@jasper-d, Thanks! This will take awhile to review and I'd like to test on a few platforms, please be patient... About signing - we did have a specific request for signed assemblies. Users tend to want both signed and unsigned assemblies, so we figured those that didn't want them signed could build this themselves, but the officially published assemblies would be signed. See: nats-io/nats.net#291. I'll take a look and test this out. |
Ok, I assumed strong naming was introduced by accident. Reverted it. Let me know if you have any questions. |
Thanks for being patient, I had to setup a linux env to test this. LGTM, and thank you for contribution! Much appreciated! |
@ColinSullivan1 Thanks for merging, didn't expect it that quickly :) We could add Linux and MacOS to the Azure Devops build matrix to add some basic verification for future contributions. |
That's a good idea. |
While working on #351, I encountered a problem when building on Linux like this:
dotnet build ./src/NATS.sln -c LinuxRelease --no-incremental --force
I took a look at the solution and project configuration (that took some time) and changed the following:
dotnet build [-c Release|Debug]
as one may expectIsWindows
andIsLinux
constantsTested these changes on Windows and Linux and it works.
Besides fixing the build on Linux, I hope that these changes make it easier to understand the setup for contributors not familiar with the code base (I had to dig through it to understand why the Linux specific platforms where used).