Check for subject and queue name validity #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Sullivan <[email protected]>
|
CI is green. |
watfordgnf
approved these changes
Aug 26, 2019
NATS.Client/Subscription.cs
Outdated
|
|
||
| private static bool IsValidTokenOrQName(string value) | ||
| { | ||
| return (!string.IsNullOrEmpty(value) && value.LastIndexOfAny(invalidSubjectChars) < 0); |
There was a problem hiding this comment.
I don't know if LastIndexOfAny has received the perf improvements that IndexOfAny has as of .NET Core.
Suggested change
| return (!string.IsNullOrEmpty(value) && value.LastIndexOfAny(invalidSubjectChars) < 0); | |
| return (!string.IsNullOrEmpty(value) && value.IndexOfAny(invalidSubjectChars) < 0); |
There was a problem hiding this comment.
Good point, thanks!
NATS.Client/Subscription.cs
Outdated
| return false; | ||
| } | ||
|
|
||
| string[] tokens = subject.Split('.'); |
There was a problem hiding this comment.
If this is ever on the hot path (e.g. Publish) we'll want to avoid Split.
There was a problem hiding this comment.
I'll add a comment.
NATS.Client/Subscription.cs
Outdated
| /// </summary> | ||
| /// <param name="subject">The subject to check</param> | ||
| /// <returns>true if valid, false otherwise.</returns> | ||
| static public bool IsValidSubject(string subject) |
There was a problem hiding this comment.
Suggested change
| static public bool IsValidSubject(string subject) | |
| public static bool IsValidSubject(string subject) |
NATS.Client/Subscription.cs
Outdated
| /// </summary> | ||
| /// <param name="queueGroup"></param> | ||
| /// <returns>true is the queue group name is valid, false otherwise.</returns> | ||
| static public bool IsValidQueueGroupName(string queueGroup) |
There was a problem hiding this comment.
Suggested change
| static public bool IsValidQueueGroupName(string queueGroup) | |
| public static bool IsValidQueueGroupName(string queueGroup) |
Signed-off-by: Colin Sullivan <[email protected]>
|
Had a change of heart on the name and usage of the private method. |
watfordgnf
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for subject and queue name validity.
See:
Resolves #280
Signed-off-by: Colin Sullivan [email protected]