Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling Drain on a closed connection throws NATSTimeoutException instead of NATSConnectionClosedException #356

Closed
jadurda opened this issue Jan 22, 2020 · 1 comment · Fixed by #359
Closed

Calling Drain on a closed connection throws NATSTimeoutException instead of NATSConnectionClosedException #356

jadurda opened this issue Jan 22, 2020 · 1 comment · Fixed by #359

Comments

@jadurda
Copy link

jadurda commented Jan 22, 2020

Any exceptions that occur during the private drain(int timeout) method gets replaced by a NATSTimeoutException. This is particularly unexpected in the case that Drain is called on a closed connection:

https://github.com/nats-io/nats.net/blob/c50d7f6854a556fbc5d0bae646d147499dc683b9/src/NATS.Client/Conn.cs#L3897-L3939
@ColinSullivan1
Copy link
Member

Good catch - thanks! I'll take a look.

ColinSullivan1 added a commit that referenced this issue Jan 24, 2020
@ColinSullivan1
Fix #356: Drain should throw NATSConnectionClosedException when appro…
25075c5 
…priate

Signed-off-by: Colin Sullivan <[email protected]>
@ColinSullivan1 ColinSullivan1 mentioned this issue Jan 24, 2020
Merged
ColinSullivan1 added a commit that referenced this issue Jan 29, 2020
@ColinSullivan1
Fix #356: Drain should throw NATSConnectionClosedException when appro…
00fec40 
…priate (#359)

Signed-off-by: Colin Sullivan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #356: Fix exceptions thrown by Drain nats-io/nats.net.v1
2 participants
@ColinSullivan1 @jadurda