Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle connection closure gracefully in consumers. #190

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Jan 14, 2025

Ensure consumers stop upon connection closure by adding proper checks and cleanup mechanisms. Added corresponding tests to validate behavior across fetch, consume, and next methods.

Ensure consumers stop upon connection closure by adding proper checks and cleanup mechanisms. Added corresponding tests to validate behavior across fetch, consume, and next methods.

Signed-off-by: Alberto Ricart <[email protected]>
Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 6543319 into main Jan 14, 2025
39 of 40 checks passed
@aricart aricart deleted the js-conn-close branch January 14, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants