Update redeliveryCount to deliveryCount across codebase #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `redeliveryCount` to `deliveryCount` to better reflect its purpose, as it tracks all delivery attempts, not just redeliveries. Updated related logic, documentation, and test cases to align with the new naming. Added a migration note for developers regarding this change. Signed-off-by: Alberto Ricart <[email protected]>
alexbozhenko
reviewed
Jan 8, 2025
| @@ -171,8 +171,8 @@ export function parseInfo(s: string): DeliveryInfo { | |||
| di.account_hash = tokens[3]; | |||
There was a problem hiding this comment.
Comment on lines 156 and 167 should be updated too?
Also, seem like there is no .random in the end?
[15523] 2025/01/08 12:07:23.854376 [TRC] 127.0.0.1:49960 - wid:31 - <<- [PUB $JS.ACK.OCB2058BMO3S4M3H1PCXP2.OCB2058BMO3S4M3H1PDB10_1.1.98.98.1736366843626007307.2 4]
[15523] 2025/01/08 12:07:23.854411 [TRC] 127.0.0.1:49960 - wid:31 - <<- MSG_PAYLOAD: ["+ACK"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
redeliveryCounttodeliveryCountto better reflect its purpose, as it tracks all delivery attempts, not just redeliveries. Updated related logic, documentation, and test cases to align with the new naming. Added a migration note for developers regarding this change.Fixes #186