Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and implement the JsMsg.next() API. #178

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Restore and implement the JsMsg.next() API. #178

merged 2 commits into from
Dec 23, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Dec 16, 2024

The JsMsg.next() method has been reintroduced and fully implemented, replacing its previous stubbed and commented-out state. This method combines ack() and pull() functionality, allowing for experimental subscription processing. The migration guide was updated to reflect the restoration of this API.

Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The `JsMsg.next()` method has been reintroduced and fully implemented, replacing its previous stubbed and commented-out state. This method combines `ack()` and `pull()` functionality, allowing for experimental subscription processing. The migration guide was updated to reflect the restoration of this API.

Signed-off-by: Alberto Ricart <[email protected]>
@aricart aricart merged commit dc70480 into main Dec 23, 2024
26 of 29 checks passed
@aricart aricart deleted the restore-js-next branch December 23, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants