Fix: duplicate message for Interest stream fails seq check in Publish…

…Ack (#1005) Co-authored-by: Scott Fauerbach <[email protected]>
nats-io · Oct 6, 2023 · 92da51e · 92da51e
1 parent 0542422
commit 92da51e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/main/java/io/nats/client/api/PublishAck.java b/src/main/java/io/nats/client/api/PublishAck.java
@@ -44,8 +44,8 @@ public PublishAck(Message msg) throws IOException, JetStreamApiException {
         if (stream == null) {
             throw new IOException("Invalid JetStream ack.");
         }
-        seq = JsonValueUtils.readLong(jv, SEQ, 0);
-        if (seq == 0) {
+        seq = JsonValueUtils.readLong(jv, SEQ, -1);
+        if (seq < 0) {
             throw new IOException("Invalid JetStream ack.");
         }
         domain = JsonValueUtils.readString(jv, DOMAIN);

diff --git a/src/test/java/io/nats/client/api/PublishAckTests.java b/src/test/java/io/nats/client/api/PublishAckTests.java
@@ -38,6 +38,22 @@ public void testValidAck() {
         }
     }
 
+    @Test
+    public void testValidAckForDuplicateWithSeq0() {
+        String json = "{\"stream\":\"test-stream\",\"seq\":0,\"domain\":\"test-domain\", \"duplicate\" : true }";
+
+        try {
+            PublishAck ack = new PublishAck(getDataMessage(json));
+            assertEquals("test-stream", ack.getStream());
+            assertEquals("test-domain", ack.getDomain());
+            assertEquals(0, ack.getSeqno());
+            assertTrue(ack.isDuplicate());
+        }
+        catch (Exception e) {
+            fail("Unexpected Exception: " + e.getMessage());
+        }
+    }
+
     @Test
     public void testThrowsOnGarbage() {
         assertThrows(JetStreamApiException.class, () -> {