Skip to content

Commit

Permalink
Unit test coverage (#1252)
Browse files Browse the repository at this point in the history
* Unit test coverage

* More coverage
  • Loading branch information
scottf authored Nov 14, 2024
1 parent f336bae commit 73611bc
Show file tree
Hide file tree
Showing 11 changed files with 145 additions and 336 deletions.
5 changes: 3 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ jacocoTestReport {
}
afterEvaluate { // only report on main library not examples
classDirectories.setFrom(files(classDirectories.files.collect {
fileTree(dir: it,
exclude: ['**/examples**'])
fileTree(dir: it, exclude: [
'**/examples/**', 'io/nats/client/support/Debug*'
])
}))
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/nats/client/Options.java
Original file line number Diff line number Diff line change
Expand Up @@ -1685,7 +1685,7 @@ public Builder serverPool(ServerPool serverPool) {
}

/**
* Set the DispatcherFactory implementation for connections to use instead of the default implementation
* Set the DispatcherFactory implementation for connections to use instead of the default implementation
* @param dispatcherFactory the implementation
* @return the Builder for chaining
*/
Expand Down
322 changes: 0 additions & 322 deletions src/main/java/io/nats/client/api/MessageBatchGetRequest.java

This file was deleted.

3 changes: 2 additions & 1 deletion src/main/java/io/nats/client/support/Validator.java
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ public static String required(String s, String label) {
return s;
}

@Deprecated
public static String required(String s1, String s2, String label) {
if (emptyAsNull(s1) == null && emptyAsNull(s2) == null) {
if (emptyAsNull(s1) == null || emptyAsNull(s2) == null) {
throw new IllegalArgumentException(label + " cannot be null or empty.");
}
return s1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ public void testSourceBase() {
assertEquals(m1, mb.build());
assertEquals(s1.hashCode(), sb.build().hashCode());
assertEquals(m1.hashCode(), mb.build().hashCode());
assertEquals(sb.subjectTransforms, m1.getSubjectTransforms());

// coverage
m.getSubjectTransforms().get(0).toString();
}

private void assertNotEqualsEqualsHashcode(Source s, Mirror m, Source.Builder sb, Mirror.Builder mb) {
Expand Down
Loading

0 comments on commit 73611bc

Please sign in to comment.