Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional note to JetStream.PullSubscribe on durable semantics #994

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Add additional note to JetStream.PullSubscribe on durable semantics #994

merged 1 commit into from
Jun 7, 2022

Conversation

bruth
Copy link
Member

@bruth bruth commented Jun 7, 2022

Based on user confusion on what the durable argument should be for an ephemeral consumer. The Subscribe method notes calls out nats.Durable, but not the argument itself.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 84.124% when pulling d069d15 on bruth:patch-1 into 8015437 on nats-io:main.

derekcollison
derekcollison approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 69f0e65 into nats-io:main Jun 7, 2022
@bruth bruth deleted the patch-1 branch June 22, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bruth @coveralls @wallyqs @derekcollison