Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Data race between processMsg() and Stats() #521

Merged
merged 1 commit into from
Sep 17, 2019
Merged

[FIXED] Data race between processMsg() and Stats() #521

merged 1 commit into from
Sep 17, 2019

Conversation

kozlovic
Copy link
Member

Resolves #520

Signed-off-by: Ivan Kozlovic [email protected]

@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 92.093% when pulling b4437f1 on fix_520 into 6ffcfbc on master.

derekcollison
derekcollison reviewed Sep 16, 2019
View reviewed changes
nats.go Outdated Show resolved Hide resolved
derekcollison
derekcollison approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit b659a00 into master Sep 17, 2019
@kozlovic kozlovic deleted the fix_520 branch September 17, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race Condition between processMsg() and Stats()
3 participants
@kozlovic @coveralls @derekcollison