Add note to README on using go get and Go modules #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -15,6 +15,17 @@ go get github.com/nats-io/nats.go/ | |||
| go get github.com/nats-io/nats-server | |||
| ``` | |||
|
|
|||
| When using Go modules (`GO111MODULE=on`): | |||
There was a problem hiding this comment.
Go 1.12 makes them on by default I think, so maybe say "When using or transitioning to Go Modules support, ..."
| go get github.com/nats-io/nats.go/@v1.8.1 | ||
|
|
||
| # Server | ||
| go get github.com/nats-io/nats-server/v2 |
There was a problem hiding this comment.
They may need or want the 1.x version so we should show an option for getting that version too, but comment it out and give a comment.
There was a problem hiding this comment.
thanks, ok made the updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go getneeds special handling with trailing slashes when using Go modules so adding to the readme (more info at #478)