Fixes to example tools #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested changes
May 17, 2019
There was a problem hiding this comment.
0 means success, and 1 means a failure. Do we want Exit(0) here? @kozlovic any opinion?
|
I think we should exit 0 at least in the case for when only showing help, then exit 1 on incorrect usage. I could add an |
|
ok I agree. |
wallyqs
force-pushed
the
example-tool-fixes
branch
2 times, most recently
from
7cb28c8 to
a6206ce
Compare
|
Applied updates to the tools so that:
|
examples/nats-bench/main.go
Outdated
| @@ -37,6 +37,10 @@ const ( | |||
| func usage() { | |||
| log.Printf("Usage: nats-bench [-s server (%s)] [--tls] [-np NUM_PUBLISHERS] [-ns NUM_SUBSCRIBERS] [-n NUM_MSGS] [-ms MESSAGE_SIZE] [-csv csvfile] <subject>\n", nats.DefaultURL) | |||
| flag.PrintDefaults() | |||
| } | |||
|
|
|||
| func showUsageAndDie() { | |||
There was a problem hiding this comment.
Maybe ShowUsageAndExit(exitcode int)?
There was a problem hiding this comment.
sounds good to me, just updated
Signed-off-by: Waldemar Quevedo <[email protected]>
wallyqs
force-pushed
the
example-tool-fixes
branch
from
a6206ce to
eabeb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply similar fix as #456 and call exit 1 after showing the tool usage/help message.
Signed-off-by: Waldemar Quevedo [email protected]