Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed DisconnectErrHandler to ConnErrHandler #464

Merged
merged 3 commits into from
May 16, 2019
Merged

renamed DisconnectErrHandler to ConnErrHandler #464

merged 3 commits into from
May 16, 2019

Conversation

mkorolyov
Copy link
Contributor

As @kozlovic proposed this PR renames handler type to be more abstract so could be reused in future.

@coveralls
Copy link

coveralls commented May 16, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 92.334% when pulling bf0284b on mkorolyov:rename_deh into 8318b38 on nats-io:master.

kozlovic
kozlovic requested changes May 16, 2019
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, would like to adjust some doc and change the option setter name (which means that you will have to update one or two tests).

kozlovic
kozlovic requested changes May 16, 2019
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@kozlovic kozlovic merged commit d65be2d into nats-io:master May 16, 2019
@mkorolyov mkorolyov deleted the rename_deh branch May 17, 2019 13:24
@danielwertheim danielwertheim mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkorolyov @coveralls @kozlovic