Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGED] DefaultURL changed to "nats://127.0.0.1:4222" #460

Merged
merged 1 commit into from
May 10, 2019

Conversation

kozlovic
Copy link
Member

Replaced to loopback ipv4 instead of localhost. In some cases,
when running the server with 127.0.0.1, if the application uses
the previous default URL (localhost), the library would resolve
this and possibly get 2 IPs (common to get 127.0.0.1 and ::1),
and it would then pick randomly one of those 2. If getting ::1,
and the server is listening on 127.0.0.1, the connection would
fail before it tries with the ipv4 address.

Also replaced reference of gnatsd with nats-server.

Signed-off-by: Ivan Kozlovic [email protected]

Replaced to loopback ipv4 instead of localhost. In some cases,
when running the server with 127.0.0.1, if the application uses
the previous default URL (localhost), the library would resolve
this and possibly get 2 IPs (common to get 127.0.0.1 and ::1),
and it would then pick randomly one of those 2. If getting ::1,
and the server is listening on 127.0.0.1, the connection would
fail before it tries with the ipv4 address.

Also replaced reference of gnatsd with nats-server.

Signed-off-by: Ivan Kozlovic <[email protected]>
@kozlovic kozlovic requested a review from derekcollison May 10, 2019 00:13
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 92.475% when pulling 8df1cb3 on change_default_url into 36d30b0 on master.

@kozlovic kozlovic merged commit d15e194 into master May 10, 2019
@kozlovic kozlovic deleted the change_default_url branch May 10, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants