Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tls handshake errors #418

Merged
merged 1 commit into from
Dec 15, 2018

Conversation

brianshannan
Copy link
Contributor

Was looking into why our nats cluster was logging occasional client side tls handshake errors, and noticed tls handshake errors in this client were being ignored.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.073% when pulling 1af8904 on brianshannan:tls_handshake_error into aa1eeb0 on nats-io:master.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@derekcollison derekcollison merged commit e0d8881 into nats-io:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants