Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto expand with multiple hosts #410

Merged
merged 3 commits into from
Nov 27, 2018
Merged

Auto expand with multiple hosts #410

merged 3 commits into from
Nov 27, 2018

Conversation

derekcollison
Copy link
Member

Allows us to auto-expand hosts that resolve to multiple IPs.

Signed-off-by: Derek Collison [email protected]

@derekcollison
Auto expand with multiple hosts
e216885 
Signed-off-by: Derek Collison <[email protected]>
@coveralls
Copy link

coveralls commented Nov 27, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 93.207% when pulling ee0dad3 on ngs into a94ae76 on master.

kozlovic
kozlovic approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nats.go Outdated Show resolved Hide resolved
nats.go Show resolved Hide resolved
@derekcollison
Expand for non-tls as well
4a48443 
Signed-off-by: Derek Collison <[email protected]>
@kozlovic
Copy link
Member

LGTM

@derekcollison
Possible multiple dials
ee0dad3 
Signed-off-by: Derek Collison <[email protected]>
kozlovic
kozlovic approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should allow the test to pass.

@derekcollison derekcollison merged commit a28ba92 into master Nov 27, 2018
@derekcollison derekcollison deleted the ngs branch November 27, 2018 20:58
@wallyqs wallyqs mentioned this pull request Feb 2, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekcollison @coveralls @kozlovic