Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nkey seed file helper and updated examples #400

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Added nkey seed file helper and updated examples #400

merged 1 commit into from
Nov 3, 2018

Conversation

derekcollison
Copy link
Member

Added a helper function that loads nkey seed from a file and wipes memory after each invocation.
Plugged it into the examples, and added an echo example.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 92.32% when pulling 9da7a9a on nkeys_examples into 507e5b3 on master.

kozlovic
kozlovic approved these changes Nov 3, 2018
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but although code added to nats.go is tested with the examples, it appears as not covered since you don't have an actual test for the new option setter.

@derekcollison derekcollison merged commit 65f34e0 into master Nov 3, 2018
@derekcollison derekcollison deleted the nkeys_examples branch November 3, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

@wallyqs wallyqs Awaiting requested review from wallyqs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekcollison @coveralls @kozlovic