Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Set connection's last error if async error occurs during Drain #392

Merged
merged 1 commit into from
Sep 6, 2018
Merged

[FIXED] Set connection's last error if async error occurs during Drain #392

merged 1 commit into from
Sep 6, 2018

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Sep 6, 2018

Resolves #391

Signed-off-by: Ivan Kozlovic [email protected]

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.216% when pulling cf39c28 on set_last_err_in_drain into fb0396e on master.

derekcollison
derekcollison approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 0856137 into master Sep 6, 2018
@kozlovic kozlovic deleted the set_last_err_in_drain branch September 6, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozlovic @coveralls @derekcollison