[IMPROVED] URL parsing allowing to skip scheme and default port #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, you could pass URL "host" and it will translate to "nats://host:4222". Also, if attempting to connect to a server that requires TLS, the Secure option will be automatically turned on and an attempt to make a secure connection will be made. Signed-off-by: Ivan Kozlovic <[email protected]>
|
@derekcollison Not sure if this is exactly what you had in mind. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, you could pass URL "host" and it will translate
to "nats://host:4222". Also, if attempting to connect to a server
that requires TLS, the Secure option will be automatically turned
on and an attempt to make a secure connection will be made.
Signed-off-by: Ivan Kozlovic [email protected]