[FIXED] Locking in processPermissionsViolation() and added test #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection locking was missing in processPermissionsViolation(). Added a test that verifies that async cb error is invoked on invalid publish or subscribe, and that the connection is not closed neither by the server nor client.
|
I think the client can not assume an error is fatal and should wait for the socket to be closed to clean up. |
|
@derekcollison Ok, so for this error, the client is not closing the connection. For stale connection, it reconnects, for all others it closes. If this needs to be changed, it should be in separate PR. Right now, this one seems to be doing the right thing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection locking was missing in processPermissionsViolation().
Added a test that verifies that async cb error is invoked on
invalid publish or subscribe, and that the connection is not
closed neither by the server nor client.
@derekcollison Opening this for discussion: was it the proper intent for the server to keep the client connection (not closing it at the moment)? If so, then it makes sense for the client also to not close it and treat this as a non fatal error. This PR then simply fixes the locking and add a test (coverage was non existent for this function).