Add FlusherTimeout to prevent blocking for long on unhealthy connections #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2017 16:10
Add customizable `FlusherTimeout` option for the flusher loop to be able to yield after a certain time in case a write to the underlying writer takes too long due to an unhealthy connection. This prevents the client blocking for an indefinite amount of time until reaching an OS level `i/o timeout` since the `bufio.Flush` is happening while the lock is being hold, thus giving room for the ping interval to be able to `processOpErr` and disconnect once it reaches the max amount of missing ping replies from the server (with an unhealthy connection the reading loop would be stuck on `conn.Read` too because there is no deadline either, so it would take as a long as the ping interval check closes the connection or `i/o timeout`).
| // Allow customizing how long we should wait for a flush to be done | ||
| // to prevent unhealthy connections blocking the client for too long. | ||
| if flusherTimeout > 0 { | ||
| conn.SetWriteDeadline(time.Now().Add(flusherTimeout)) |
There was a problem hiding this comment.
Thanks for checking, I added resetting the WriteDeadline on successful flush now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a customizable
FlusherTimeoutoption for the flusher loop to be able to yield after a certain time in case a write to the underlying writer takes too long due to an unhealthy connection.This prevents the client blocking for an indefinite amount of time until reaching an OS level
i/o timeoutsince thebufio.Flushis happening while the lock is being hold, thus giving room for the ping interval to be able toprocessOpErrand disconnect once it reaches the max amount of missing ping replies from the server (with an unhealthy connection the reading loop would be stuck onconn.Readtoo because there is no deadline either, so it would take as a long as the ping interval check closes the connection ori/o timeout).