[FIXED] Add discard policy repair logic in CreateKeyValue #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <[email protected]>
ripienaar
reviewed
Apr 18, 2024
| // is the discard policy, we will update the stream. | ||
| if stream, _ = js.Stream(ctx, scfg.Name); stream != nil { | ||
| cfg := stream.CachedInfo().Config | ||
| cfg.Discard = scfg.Discard |
There was a problem hiding this comment.
just on the off chance an ancient bucket is accessed lets also set AllowDirect otherwise lgtm!
Signed-off-by: Piotr Piotrowski <[email protected]>
Merged
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski [email protected]