Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] UpdateObjectStore and CreateOrUpdateObjectStore methods #1550

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Feb 8, 2024

Similar changes to #1549, only for object store.

I'll be updating the documentation for the whole object store in the next PR.

Signed-off-by: Piotr Piotrowski [email protected]

@piotrpio piotrpio requested a review from Jarema February 8, 2024 12:52
@piotrpio piotrpio force-pushed the add-update-to-object-store branch 2 times, most recently from 6a263c8 to a315493 Compare February 8, 2024 12:53
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One nit on comment.

jetstream/object.go Outdated Show resolved Hide resolved
Co-authored-by: Tomasz Pietrek <[email protected]>
@piotrpio piotrpio merged commit 3fd6eb5 into main Feb 9, 2024
1 of 2 checks passed
@piotrpio piotrpio mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants