Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async publish PAF id #1476

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix async publish PAF id #1476

merged 2 commits into from
Nov 28, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Nov 21, 2023

The length of the async pub ack prefix was a constant, while it should no be.
In case of custom inbox prefix, the ID was not properly calculated.
Fortunately it could never lead to out of range issues, but it could increase collision for map id in case of very short inbox prefixes.

Signed-off-by: Tomasz Pietrek [email protected]

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit bb64e1b into main Nov 28, 2023
2 checks passed
@piotrpio piotrpio mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants