[ADDED] TLSHandshakeFirst option #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to connect to a server that is also configured to perform the TLS handshake first, that is, before sending the INFO protocol. Signed-off-by: Ivan Kozlovic <[email protected]>
piotrpio
approved these changes
Oct 9, 2023
@piotrpio Actually no. The server relies on the client new API for its tests. I made the client not depend on the server for the test (since it is quite simple here), but not the server. If you merge and soon after have to do a release while the server still does not have the feature, then it would have to be stated in the client's release notes that this option is to be used with servers at version x.y.z and above. |
|
@kozlovic Got it - in that case, I'm merging the PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to connect to a server that is also configured to perform the TLS handshake first, that is, before sending the INFO protocol.
Signed-off-by: Ivan Kozlovic [email protected]