[ADDED] Setting TLS config with callbacks in Connect #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
force-pushed
the
client-cert-cb
branch
from
b2d31a0
to
305461f
Compare
|
Hey @piotrpio is there any progress on this? This addition would be useful. Happy to help if there is anything. |
Jarema
reviewed
Feb 15, 2024
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
client-cert-cb
branch
from
305461f
to
a7632e5
Compare
|
Love this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to load TLS config with custom callbacks. Previously it was only possible to either set the whole
TLSConfiginnats.Secure()(which is not reloaded on reconnect) or pass files tonats.ClientCert()andnats.RootCAs()options.Adding this function increases flexibility and is consistent with what we do for credentials in
nats.UserJWT()option.