Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ADDED] Support for stream subject transform" #1220

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

piotrpio
Copy link
Collaborator

Reverts #1200 - this functionality will be added after [email protected] release

@piotrpio piotrpio requested a review from Jarema February 24, 2023 09:34
@piotrpio piotrpio force-pushed the revert-1200-jnm/streamsourcetransform branch from 5de2713 to b63075f Compare February 24, 2023 09:40
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming green CI.

@piotrpio piotrpio merged commit c86a1a1 into main Feb 24, 2023
@coveralls
Copy link

Coverage Status

Coverage: 85.416% (+0.1%) from 85.297% when pulling b63075f on revert-1200-jnm/streamsourcetransform into 090ea10 on main.

@piotrpio piotrpio deleted the revert-1200-jnm/streamsourcetransform branch February 24, 2023 14:14
@wallyqs
Copy link
Member

wallyqs commented Feb 24, 2023

This is fine too since in the server still locking to v1.23 release: https://github.com/nats-io/nats-server/blob/main/go.mod#L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants