Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHANGED] Service API adjustments #1166

Merged
merged 2 commits into from
Dec 22, 2022
Merged

[CHANGED] Service API adjustments #1166

merged 2 commits into from
Dec 22, 2022

Conversation

piotrpio
Copy link
Collaborator

  • got rid of uppercasing the monitoring subjects
  • removed error from RequestHandler signature
  • count respond errors in stats

@piotrpio piotrpio requested a review from Jarema December 21, 2022 11:23
@coveralls
Copy link

coveralls commented Dec 21, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 85.462% when pulling b68dad6 on services-fix into 61a9345 on main.

wallyqs
wallyqs approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aricart
aricart approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit e350a6f into main Dec 22, 2022
@piotrpio piotrpio deleted the services-fix branch December 22, 2022 13:40
@piotrpio piotrpio mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

@wallyqs wallyqs wallyqs approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrpio @coveralls @wallyqs @aricart