Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Comment on RetryOnFailedConnect #1127

Merged
merged 2 commits into from
Nov 8, 2022
Merged

[IMPROVED] Comment on RetryOnFailedConnect #1127

merged 2 commits into from
Nov 8, 2022

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Nov 8, 2022

Addresses #1109

@piotrpio piotrpio requested a review from Jarema November 8, 2022 12:36
Jarema
Jarema reviewed Nov 8, 2022
View reviewed changes
nats.go Outdated Show resolved Hide resolved
@piotrpio @Jarema
Update nats.go
01a6ddc 
Co-authored-by: Tomasz Pietrek <[email protected]>
Jarema
Jarema approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.757% when pulling 01a6ddc on retryonfailedconnect-comment-fix into 980f955 on main.

@piotrpio piotrpio merged commit be36353 into main Nov 8, 2022
@piotrpio piotrpio deleted the retryonfailedconnect-comment-fix branch November 8, 2022 13:07
This was referenced Nov 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrpio @coveralls @Jarema