Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Trailing comma at end of URL lists should be ignored #1058

Merged
merged 1 commit into from
Aug 30, 2022
Merged

[FIXED] Trailing comma at end of URL lists should be ignored #1058

merged 1 commit into from
Aug 30, 2022

Conversation

kozlovic
Copy link
Member

Resolves #1056

Signed-off-by: Ivan Kozlovic [email protected]

@kozlovic kozlovic requested a review from piotrpio August 30, 2022 19:35
@kozlovic
Copy link
Member Author

@piotrpio I see that Derek assigned this to you, but I had started looking at this when Marco reported the issue. Hope it is ok.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 85.557% when pulling f6c1a78 on fix_1056 into 0797ed6 on main.

derekcollison
derekcollison approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 6de9cf0 into main Aug 30, 2022
@kozlovic kozlovic deleted the fix_1056 branch August 30, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATS client connecting to local server due to stray comma in connect string
3 participants
@kozlovic @coveralls @derekcollison