Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UserJWTAndSeed helper function #1046

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

bruth
Copy link
Member

@bruth bruth commented Aug 12, 2022

The motivation for this is to support situations when the JWT and seed are passed as environment variables or other means that don't rely on a file, such as environments only supporting environment variables.

The motivation for this is to support situations when
the JWT and seed are passed as environment variables or
other means that don't rely on a file.

Signed-off-by: Byron Ruth <[email protected]>
@bruth bruth requested a review from kozlovic August 12, 2022 18:32
@bruth
Copy link
Member Author

bruth commented Aug 12, 2022

Appears the failure occurred on an unrelated test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 85.61% when pulling 893829b on bruth:creds-by-value into fb5ca2c on nats-io:main.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 30d5319 into nats-io:main Aug 12, 2022
@bruth bruth deleted the creds-by-value branch August 15, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants