-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Direct Gets by subject #1030
Conversation
@codegangsta Also, unrelated to your PR, but since you updated the server version, and due to @bruth recent change in the server, this test fails:
would need to be updated in order for the Travis CI to pass. Could you do it? |
Sure I'll take a look |
Meaning that server does not support it, so the test should not try to modify or at least not expect it to be updated :-) |
@kozlovic looks like this may be a flaky test?
I'll run it again |
@kozlovic all passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR brings in client support for nats-io/nats-server#3325, which adds server support for direct gets by a particular subject. This should now allow direct gets to work with KVs properly