Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Direct Gets by subject #1030

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Conversation

codegangsta
Copy link
Contributor

This PR brings in client support for nats-io/nats-server#3325, which adds server support for direct gets by a particular subject. This should now allow direct gets to work with KVs properly

test/js_test.go Outdated Show resolved Hide resolved
go_test.mod Outdated Show resolved Hide resolved
@kozlovic
Copy link
Member

kozlovic commented Aug 3, 2022

@codegangsta Also, unrelated to your PR, but since you updated the server version, and due to @bruth recent change in the server, this test fails:

=== RUN   TestJetStreamManagement/update_consumer
    js_test.go:1417: Error on update: max waiting can not be updated

would need to be updated in order for the Travis CI to pass. Could you do it?

@codegangsta
Copy link
Contributor Author

Sure I'll take a look

@kozlovic
Copy link
Member

kozlovic commented Aug 3, 2022

Meaning that server does not support it, so the test should not try to modify or at least not expect it to be updated :-)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 85.721% when pulling e7a08b8 on JMS-DirectGetLastBySubject into 59d7d9c on main.

@codegangsta
Copy link
Contributor Author

@kozlovic looks like this may be a flaky test?

=== RUN   TestHotSpotReconnect
    cluster_test.go:341: Connected clients to server: nats://127.0.0.1:1226 out of range: 23

I'll run it again

@codegangsta
Copy link
Contributor Author

@kozlovic all passed!

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants