Added support for Subject reporting on StreamInfo requests #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jsm.go
Outdated
| DeletedDetails bool `json:"deleted_details,omitempty"` | ||
| // SubjectsFilter When set, returns information on the matched subjects - can be a wildcard or wild-carded subject |
There was a problem hiding this comment.
when set (lower) and wildcarded
kozlovic
requested changes
Jun 29, 2022
piotrpio
requested changes
Jun 29, 2022
piotrpio
requested changes
Jun 29, 2022
| @@ -1702,6 +1702,42 @@ func TestPurgeStream(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestStreamInfoSubjectInfo(t *testing.T) { | |||
There was a problem hiding this comment.
There already is a test called TestStreamInfo which tests basic stream info request (without parameters) as well as request with DeletedDetails == true.
So it would be nice to either extend this existing test with additional cases for SubjectInfo or at least rename TestStreamInfo to e.g. TestStreamInfoDeletedDetails to be consistent in naming.
There was a problem hiding this comment.
Renaming the other test to TestStreamInfoDeletedDetails
…a subject/wildcard that instruct the request to provide information on matching subjects in `StreamState`. [FEAT] added `NumSubjects` to `StreamState` enabling report for the number of subjects in the stream [FEAT] added `Subjects` to `StreamState` a map of subject to number of messages in the subject which gets populated if the `StreamInfoRequest` specifies a `SubjectFilter` FIX #1009
piotrpio
approved these changes
Jun 29, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FEAT] added
SubjectFiltertoStreamInfoRequest. The field takes a subject/wildcard that instruct the request to provide information on matching subjects inStreamState.[FEAT] added
NumSubjectstoStreamStateenabling report for the number of subjects in the stream[FEAT] added
SubjectstoStreamStatea map of subject to the number of messages with the subject which gets populated if theStreamInfoRequestspecifies aSubjectFilterFIX #1009