[FIX] flusher timers #526
Merged
[FIX] flusher timers #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
Jun 1, 2023
…ta than can fit into the outbound buffer, an inline flush happens - but on the first command sent to the server, an auto-flush is scheduled on the next event loop. The timer for this auto-schedule flush was not managed, so in a bench type scenario where the client is trying to send significant amount of data, the timers accumulate degrading the performance of the client. This fix removes the scheduled timer whenever an inline flush happens, greatly improving the performance of the client in this type of scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a fast producer dominates the event loop and sends more data than can fit into the outbound buffer, an inline flush happens - but on the first command sent to the server, an auto-flush is scheduled on the next event loop. The timer for this auto-schedule flush was not managed.
In a bench-type scenario where the client is trying to send a significant amount of data, the timers accumulate, degrading the client's performance. This fix removes the scheduled timer whenever an inline flush happens, greatly improving the client's performance.