Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetstream module #521

Merged
merged 4 commits into from
May 30, 2023
Merged

jetstream module #521

merged 4 commits into from
May 30, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented May 24, 2023

Reorganize code base to eliminate circular dependencies and allow for possible external modules

@aricart aricart temporarily deployed to CI May 25, 2023 15:19 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI May 25, 2023 19:53 — with GitHub Actions Inactive
…l create the deps as long as core references jetstream) and jetstream not have circular dependencies
@aricart aricart temporarily deployed to CI May 25, 2023 20:33 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI May 25, 2023 20:58 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI May 25, 2023 21:23 — with GitHub Actions Inactive
@aricart aricart marked this pull request as ready for review May 26, 2023 14:30
@aricart aricart requested a review from Jarema May 26, 2023 14:30
@aricart aricart changed the title Js module jetstream module May 26, 2023
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aricart aricart merged commit da70f02 into dev May 30, 2023
@aricart aricart deleted the js-module branch May 30, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants