Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove ack() from a PubAck this feature was never supported #511

Merged
merged 1 commit into from
May 15, 2023
Merged

[FIX] remove ack() from a PubAck this feature was never supported #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nats-base-client/jsclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ export class JetStreamClientImpl extends BaseApiClient
}
}
}

const pa = this.parseJsResponse(r!) as PubAck;
if (pa.stream === "") {
throw NatsError.errorForCode(ErrorCode.JetStreamInvalidAck);
Expand Down
5 changes: 0 additions & 5 deletions nats-base-client/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,11 +844,6 @@ export interface PubAck {
* True if the message is a duplicate
*/
duplicate: boolean;

/**
* Acknowledges the PubAck back to the server
*/
ack(): void;
}

/**
Expand Down