Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] multiple authenticators #472

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[FEAT] multiple authenticators #472

merged 1 commit into from
Jan 25, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Jan 24, 2023

  • it is now possible to specify multiple authenticators, previously this was rejected by the client.
  • all generated/specified authenticators are aggregated, and their authentication results are aggregated. Note that creds and jwt authenticators write the nkey and sig properties, so if both are specified, it is important that they both use the same nkey.

@aricart
[FEAT] authenticator connection option can now be an array of authent…
77c002a 
…icators - this means that now, setting up user/pass, token and a creds authenticator, etc is legal - previously such combinations were rejected.
@aricart aricart changed the base branch from main to dev January 24, 2023 21:33
@aricart aricart requested a review from derekcollison January 24, 2023 21:34
derekcollison
derekcollison approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - caveats though, not TS person.

piotrpio
piotrpio approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aricart aricart merged commit bb97326 into dev Jan 25, 2023
@aricart aricart deleted the multiple-authenticators branch January 25, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aricart @derekcollison @piotrpio