Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] [TEST] fixed a flapper test #458

Merged
merged 4 commits into from
Jan 12, 2023
Merged

[FIX] [TEST] fixed a flapper test #458

merged 4 commits into from
Jan 12, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Jan 12, 2023 •
edited
Loading

fixed some tests that have been flapping recently, as well as corrected logging output.

@aricart aricart temporarily deployed to CI January 12, 2023 16:38 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI January 12, 2023 16:47 — with GitHub Actions Inactive
@aricart
remove client logging
02089a3 
[FIX] [TEST] fixed flappers
@aricart aricart temporarily deployed to CI January 12, 2023 16:50 — with GitHub Actions Inactive
@aricart aricart marked this pull request as ready for review January 12, 2023 16:51
@aricart aricart requested a review from piotrpio January 12, 2023 16:51
piotrpio
piotrpio approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart requested review from piotrpio and scottf January 12, 2023 16:59
scottf
scottf approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart temporarily deployed to CI January 12, 2023 17:00 — with GitHub Actions Inactive
@aricart
[FIX] [TEST] undid the removal of the lint, because if we don't wait …
eba4e66 
…for the output promise, deno complains of resources open
@aricart aricart temporarily deployed to CI January 12, 2023 17:21 — with GitHub Actions Inactive
@aricart aricart merged commit c8d0410 into main Jan 12, 2023
@aricart aricart deleted the fix-flapper branch January 12, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf approved these changes

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aricart @scottf @piotrpio