Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] remove remembering of a permissions error #406

Merged
merged 2 commits into from
Nov 15, 2022
Merged

[FIX] remove remembering of a permissions error #406

merged 2 commits into from
Nov 15, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 15, 2022

FIX #530

@aricart aricart requested a review from kozlovic November 15, 2022 15:33
kozlovic
kozlovic approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 28f58e2 into dev Nov 15, 2022
@aricart aricart deleted the last-error branch November 15, 2022 21:38
aricart added a commit that referenced this pull request Nov 17, 2022
@aricart
[FIX] remove remembering of a permissions error (#406)
196f64f 
#406
FIX #530
# Conflicts:
#	tests/auth_test.ts
aricart added a commit that referenced this pull request Nov 17, 2022
@aricart
Merging two fixes from dev that remove ambiguity on connection errors (…
3b8e316 
…#410)

* [FIX] fixed a condition where a subscription that received a permissions error was not reaped. (#408)

* [FIX] remove remembering of a permissions error (#406)
#406
FIX #530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aricart @kozlovic