[FIXED] Randomize discovered server URLs if allowed #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If randomize is allowed, discovered URLs will be randomly added to the pool of urls instead of always be appended. See nats-io/nats.go#565 Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
changed the title
|
Need to update based on changes made to the Go client. Namely, need to ensure that we don't shuffle the whole pool but leave the first URL untouched. |
Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If randomize is allowed, discovered URLs will be randomly added
to the pool of urls instead of always be appended.
See nats-io/nats.go#565
Signed-off-by: Ivan Kozlovic [email protected]