Deny/Allow Permissions #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
2 tasks
Signed-off-by: Derek Collison <[email protected]>
|
ok now that routes added in its ready for review. |
kozlovic
requested changes
Aug 23, 2018
| @@ -575,17 +593,73 @@ func parseSubjects(v interface{}) ([]string, error) { | |||
| default: | |||
| return nil, fmt.Errorf("Expected subject permissions to be a subject, or array of subjects, got %T", v) | |||
| } | |||
| return checkSubjectArray(subjects) | |||
There was a problem hiding this comment.
Why we don't check for validity here?
There was a problem hiding this comment.
You are correct, need to rework this and use parseSubject() more. I see duplicate code. One sec.
server/sublist.go
Outdated
| @@ -92,7 +92,8 @@ func newLevel() *level { | |||
|
|
|||
| // New will create a default sublist | |||
| func NewSublist() *Sublist { | |||
| return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)} | |||
| // return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)} | |||
There was a problem hiding this comment.
Is that intentional? If you don't create the cache here, it will never be created therefore used.
There was a problem hiding this comment.
This was me playing with other things, should not be in here. Will remove.
server/sublist.go
Outdated
| for k := range s.cache { | ||
| delete(s.cache, k) | ||
| break | ||
| if s.cache != nil { |
There was a problem hiding this comment.
I think all code in sublist assumes the cache is not nil since it is (was) created in NewSublist().
| allow = "foo.*" | ||
| deny = "foo.baz" | ||
| } | ||
| } |
There was a problem hiding this comment.
Not that it matters but newline?
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
Signed-off-by: Derek Collison <[email protected]>
kozlovic
approved these changes
Aug 23, 2018
|
LGTM |
kozlovic
added a commit
that referenced
this pull request
Aug 27, 2018
This is an issue in master only, not in any public release. The issue is that permissions should be assigned as-is for the route perms because Publish/Subscribe could be nil, so trying to dereference Publish.Allow/Deny or Subscribe.Allow/Deny could crash. The code checking for permissions correctly check if Publish/Subscribe is nil or not. This was introduced with PR #725 Signed-off-by: Ivan Kozlovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to express deny attributes for publish and subscribe permissions. Old behavior and configuration syntax is preserved. This adds a third type to the configuration with allow and deny.
e.g.
/cc @nats-io/core