Improve error message when attempting to change consumer type #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/jetstream_test.go
Outdated
| AckPolicy: nats.AckExplicitPolicy, | ||
| DeliverSubject: "foo", | ||
| }) | ||
| if !strings.Contains(err.Error(), "can not update pull consumer to push based") { |
There was a problem hiding this comment.
Minor nit but assertions like require_Equals(err.Error(), "can not update pull consumer to push based") are better not just because they are cleaner but because they properly integrate with the Antithesis SDK assertions.
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
improve-update-consumer-error
branch
from
bea3f58 to
d408266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, an attempt to change consumer type (by either setting or removing deliver subject), resulted in
max waiting can not be updatederror asMaxWaitinghas a default value for pull consumers. This ensures that changing consumer type is checked before max waiting to return a more useful error message.Signed-off-by: Piotr Piotrowski [email protected]