[FIXED] Notifying waiting pull consumers on consumer or parent stream deletion. #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <[email protected]>
derekcollison
force-pushed
the
fix-3606
branch
from
d916691 to
72ff2ed
Compare
kozlovic
approved these changes
Nov 3, 2022
| if o.mset == nil || o.outq == nil || o.waiting.len() == 0 { | ||
| return | ||
| } | ||
| hdr := []byte("NATS/1.0 409 Consumer Deleted\r\n\r\n") |
There was a problem hiding this comment.
I guess we don't need to send the pending msgs/bytes in this case since the consumer is deleted.
There was a problem hiding this comment.
I think that is correct, but should we add it?
There was a problem hiding this comment.
Again, since the consumer is really gone, I am not sure what the library will do with the extra info, but we could just to be consistent.
There was a problem hiding this comment.
True but we would want to surface consumer deleted IMO, not subscription closed etc.
kozlovic
approved these changes
Nov 3, 2022
| if o.mset == nil || o.outq == nil || o.waiting.len() == 0 { | ||
| return | ||
| } | ||
| hdr := []byte("NATS/1.0 409 Consumer Deleted\r\n\r\n") |
There was a problem hiding this comment.
Again, since the consumer is really gone, I am not sure what the library will do with the extra info, but we could just to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison [email protected]
Resolves #3603
/cc @nats-io/core