Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure file path is correct during stream restore #2917

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Mar 9, 2022

Also had to change all references from path. to filepath. when
dealing with files, so that it works properly on Windows.

Fixed also lots of tests to defer the shutdown of the server
after the removal of the storage, and fixed some config files
directories to use the single quote ' to surround the file path,
again to work on Windows.

Signed-off-by: Ivan Kozlovic [email protected]

@kozlovic kozlovic force-pushed the file_path branch 2 times, most recently from 04e93a6 to 15563e5 Compare March 9, 2022 20:10
Copy link
Contributor

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also had to change all references from `path.` to `filepath.` when
dealing with files, so that it works properly on Windows.

Fixed also lots of tests to defer the shutdown of the server
after the removal of the storage, and fixed some config files
directories to use the single quote `'` to surround the file path,
again to work on Windows.

Signed-off-by: Ivan Kozlovic <[email protected]>
@kozlovic kozlovic merged commit 818c2c7 into main Mar 9, 2022
@kozlovic kozlovic deleted the file_path branch March 9, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants